Thread (6 messages) 6 messages, 3 authors, 2012-06-12

Re: [patch] can: c_can: precedence error in c_can_chip_config()

flat view

From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: 2012-06-12 11:01:19
Also in: kernel-janitors, linux-can

On 12.06.2012 11:37, Marc Kleine-Budde wrote:
On 06/11/2012 07:42 PM, Oliver Hartkopp wrote:
quoted
On 10.06.2012 19:52, Marc Kleine-Budde wrote:
quoted
On 06/09/2012 05:56 PM, Dan Carpenter wrote:
quoted
(CAN_CTRLMODE_LISTENONLY & CAN_CTRLMODE_LOOPBACK) is (0x02 & 0x01) which
is zero so the condition is never true.  The intent here was to test
that both flags were set.

Signed-off-by: Dan Carpenter <redacted>
---
This is a static checker fix.  I'm not super familiar with the c_can
code.
Good catch. Applied to can-next.

Marc

Shouldn't this fix go through the net-tree and stable instead of net-next?
Can I add your Acked-by ... when adding to net?

Yes you can :-)

Oliver
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help