Re: [patch] can: c_can: precedence error in c_can_chip_config()

On 06/11/2012 07:42 PM, Oliver Hartkopp wrote:

On 10.06.2012 19:52, Marc Kleine-Budde wrote:

quoted

On 06/09/2012 05:56 PM, Dan Carpenter wrote:

quoted

(CAN_CTRLMODE_LISTENONLY & CAN_CTRLMODE_LOOPBACK) is (0x02 & 0x01) which
is zero so the condition is never true.  The intent here was to test
that both flags were set.

Signed-off-by: Dan Carpenter <redacted>
---
This is a static checker fix.  I'm not super familiar with the c_can
code.

Good catch. Applied to can-next.

Marc

Shouldn't this fix go through the net-tree and stable instead of net-next?

Indeed.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |