RE: [PATCH 1/1] atl1c: fix issue of transmit queue 0 timed out

Luis
   It should be a stable fix, but as Ben Hutchings mentioned in another mail, 
Maybe, removing netif_stop_queue when cable link down is a better choice.

   Do you mean we need add 'cc:stable@vger.kernel.org'  just before 'some people report  ...' ?

Thanks
Xiong

-----Original Message-----
From: Rodriguez, Luis
Sent: Wednesday, June 27, 2012 2:03
To: Ren, Cloud
Cc: davem@davemloft.net; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org; qca-linux-team; nic-devel; Huang, Xiong
Subject: Re: [PATCH 1/1] atl1c: fix issue of transmit queue 0 timed out

On Tue, Jun 26, 2012 at 12:33:06PM -0300, Ren, Cloud wrote:

quoted

From: xiong <redacted>

some people report atl1c could cause system hang with following kernel
trace info:
---------------------------------------
WARNING: at.../net/sched/sch_generic.c:258
dev_watchdog+0x1db/0x1d0()
...
NETDEV WATCHDOG: eth0 (atl1c): transmit queue 0 timed out ...
---------------------------------------
This is caused by netif_stop_queue calling when cable Link is down but
netif_wake_queue isn't called when cable Link is resume.

Signed-off-by: xiong <redacted>
Signed-off-by: Cloud Ren <redacted>

If this fixes  a system hang then this could be a stable fix -- that is, this should
be propagated to older stable kernels, no?

If so then please add to the commit log a line like this:

Cc: stable@vger.kernel.org [3.4]

Note: this is for the commit log! Right above the line below that has "---"

  Luis