Re: [PATCH] virtio-net: fix a race on 32bit arches

On Wed, 2012-06-06 at 21:19 +0100, Ben Hutchings wrote:

On Wed, 2012-06-06 at 22:08 +0200, Eric Dumazet wrote:

quoted

On Wed, 2012-06-06 at 22:58 +0300, Michael S. Tsirkin wrote:

quoted

Absolutely, I am talking about virtio here.  I'm not kicking
u64_stats_sync idea I am just saying that simple locking
would work for virtio and might be better as it
gives us a way to get counters atomically.

Which lock do you own in the RX path ?

You'll have to add a lock in fast path. This sounds really a bad choice
to me.

You have the NAPI 'lock', so when gathering stats you can synchronise
using napi_disable() ;-)

Nice, this adds one new bug in network stack.

Really guys, can we stop this thread, please ?