Re: [PATCH] virtio-net: fix a race on 32bit arches

On Wed, 2012-06-06 at 23:16 +0300, Michael S. Tsirkin wrote:

On Wed, Jun 06, 2012 at 10:08:09PM +0200, Eric Dumazet wrote:

quoted

On Wed, 2012-06-06 at 22:58 +0300, Michael S. Tsirkin wrote:

quoted

Absolutely, I am talking about virtio here.  I'm not kicking
u64_stats_sync idea I am just saying that simple locking
would work for virtio and might be better as it
gives us a way to get counters atomically.

Which lock do you own in the RX path ?

We can just disable napi, everything is updated from napi callback.

This is very disruptive, and illegal from ndo_get_stats64()

(ndo_get_stats64() is not allowed to sleep, and I cant see how you are
going to disable napi without sleeping)