Thread (7 messages) flat view 7 messages, 2 authors, 2012-06-06

RE: [net-next PATCH v2 1/3] Added kernel support in EEE Ethtool commands

From: Yuval Mintz <hidden>
Date: 2012-06-06 16:40:22

quoted
+ * @supported: Link speeds for which there is eee support.
+ * @advertised: Link speeds the interface advertises (AN) as eee capable.
+ * @lp_advertised: Link speeds the link partner advertised as eee capable.
And these are bitmasks of SUPPORTED_* & ADVERTISED_* flags, right?
Right.
Maybe 'link modes' not 'link speeds'?
Not that it matters greatly, but there are SUPPORTED & ADVERTISED flags for
things other than link speeds, such as connection type and flow control,
so using exactly the same semantic in description might confuse someone.

Thank,
Yuval 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help