Re: [net-next PATCH v2 1/3] Added kernel support in EEE Ethtool commands
From: Ben Hutchings <hidden>
Date: 2012-06-06 15:20:18
On Wed, 2012-06-06 at 11:58 +0300, Yuval Mintz wrote:
quoted hunk ↗ jump to hunk
This patch extends the kernel's ethtool interface by adding support for 2 new EEE commands - get_eee and set_eee. Thanks goes to Giuseppe Cavallaro for his original patch adding this support. Signed-off-by: Yuval Mintz <redacted> Signed-off-by: Eilon Greenstein <redacted> --- include/linux/ethtool.h | 32 ++++++++++++++++++++++++++++++++ net/core/ethtool.c | 40 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 72 insertions(+), 0 deletions(-)diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h index e17fa71..6250e1f 100644 --- a/include/linux/ethtool.h +++ b/include/linux/ethtool.h@@ -137,6 +137,32 @@ struct ethtool_eeprom { }; /** + * struct ethtool_eee - Energy Efficient Ethernet information + * @cmd: ETHTOOL_{G,S}EEE + * @supported: Link speeds for which there is eee support. + * @advertised: Link speeds the interface advertises (AN) as eee capable. + * @lp_advertised: Link speeds the link partner advertised as eee capable.
And these are bitmasks of SUPPORTED_* & ADVERTISED_* flags, right? Maybe 'link modes' not 'link speeds'? Otherwise, this all looks good to me (with limited knowledge of EEE). Ben.
+ * @eee_active: Result of the eee auto negotiation.
+ * @eee_enabled: EEE configured mode (enabled/disabled).
+ * @tx_lpi_enabled: Whether the interface should assert its tx lpi, given
+ * that eee was negotiated.
+ * @tx_lpi_timer: Time in microseconds the interface delays prior to asserting
+ * its tx lpi (after reaching 'idle' state). Effective only when eee
+ * was negotiated and tx_lpi_enabled was set.
+ */
+struct ethtool_eee {[...] -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.