Thread (8 messages) 8 messages, 3 authors, 2012-05-29

Re: [PATCH] r6040: disable pci device if the subsequent calls (after pci_enable_device) fails

From: devendra.aaru <hidden>
Date: 2012-05-29 23:19:20
Also in: lkml

Hi David,

On Wed, May 30, 2012 at 2:58 AM, David Miller [off-list ref] wrote:
From: David Miller <davem@davemloft.net>
Date: Tue, 29 May 2012 17:22:29 -0400 (EDT)

Actually, reverted, you didn't test this patch at all.

You didn't even look at the warnings emitted by the compiler
with your changes installed.

You're passing a network device pointer into the PCI device
disable routine, which takes a PCI device pointer.

I can't express to you how extremely irritating it is when
people submit patches like this.

The bug in question is 1,000 times less harmful than your fix.
Sorry about that, i agree that i didn't even tested it as i dont have
r6040 network adapter here, but i didn't even compiled it.

i sent the patch again to fix this problem.

Sorry,
Devendra.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help