From: David Miller <davem@davemloft.net>
Date: Tue, 29 May 2012 17:22:29 -0400 (EDT)

From: Florian Fainelli <florian@openwrt.org>
Date: Tue, 29 May 2012 11:20:50 +0200

quoted

On Monday 28 May 2012 17:27:03 Devendra Naga wrote:

quoted

the calls after the pci_enable_device may fail, and will error out with out
disabling it. disable the device at error paths.

Looks good, thanks Devendra!

quoted

Signed-off-by: Devendra Naga <redacted>

Acked-by: Florian Fainelli <florian@openwrt.org>

Applied.

Actually, reverted, you didn't test this patch at all.

You didn't even look at the warnings emitted by the compiler
with your changes installed.

You're passing a network device pointer into the PCI device
disable routine, which takes a PCI device pointer.

I can't express to you how extremely irritating it is when
people submit patches like this.

The bug in question is 1,000 times less harmful than your fix.