Re: [RFC net-next 0/2] net: Use net_<level>_ratelimit

From: Johannes Berg <redacted>
Date: Tue, 15 May 2012 20:21:34 +0200

On Tue, 2012-05-15 at 14:13 -0400, David Miller wrote:

quoted

From: Johannes Berg <redacted>
Date: Tue, 15 May 2012 20:03:48 +0200

quoted

Oops. Yes, please do that, mac80211 doesn't have DEBUG yet

If you want debugging messages you would turn on dynamic_debug
via sysctl or whatever, not define DEBUG in your sources.

I don't think we should add yet another interface just to get
KERN_DEBUG in there.

But don't you have to do something in the sources to actually get
dynamic_debug enabled? I'm concerned this will make mac80211 debugging
inconsistent - the normal bits are just printk() still, and the
rate-limited bits need some special enabling? That seems odd.

You can turn them all off or on with a simple flip of a boolean switch
at run-time.  Or, alternatively, you can turn them on or off in a
finer grained manner with other run-time facilities.

There should be a transition away from explicit KERN_DEBUG.