Thread (4 messages) flat view 4 messages, 2 authors, 2012-05-15

Re: [RFC net-next 0/2] net: Use net_<level>_ratelimit

From: Johannes Berg <hidden>
Date: 2012-05-15 18:27:18
Also in: linux-nfs, linux-sctp, linux-wireless, lkml, netfilter-devel

On Tue, 2012-05-15 at 10:59 -0700, Joe Perches wrote:
OK, but fyi, there's a possible issue with !CONFIG_DEBUG
builds because these patches converted some uses of
	if (net_ratelimit())
		printk(KERN_DEBUG ...
to
	net_dbg_ratelimited()

These messages are no longer emitted when DEBUG isn't defined
and not using dynamic_debug.  I'm not sure that's a real
problem, but it's a difference.

I could produce a net_printk_ratelimited that would keep
the original behavior if necessary.

	net_printk_ratelimited(KERN_DEBUG etc...)
Btw, what would the difference be to just plain printk_ratelimited()?

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help