Re: [PATCH v3] drop_monitor: convert to modular building
From: Neil Horman <nhorman@tuxdriver.com>
Date: 2012-05-29 19:33:55
On Tue, May 22, 2012 at 03:05:19PM +0200, Eric Dumazet wrote:
On Thu, 2012-05-17 at 16:21 -0400, Neil Horman wrote:quoted
On Thu, May 17, 2012 at 04:09:37PM -0400, David Miller wrote:quoted
quoted
Applied, althrough it didn't apply cleanly to net-next.Apologies Dave, should have told you that I was carrying Joe P.'s cleanup patch in my net-next tree as well: http://marc.info/?l=linux-netdev&m=133727344816140&w=2 Since you noted that you had applied it, I applied it myself here. NeilAny plan to autoload drop_monitor module from dropwatch, or issuing some advice ? # dropwatch -l kas Unable to find NET_DM family, dropwatch can't work Cleanuing up on socket creation error Thanks
Eric, Just FYI, I sent a series upstream to implement autoloading of generic netlink families. Please be awarem, that I've tested these with a hacked version of dropwatch, and it works great, but with the normal version of dropwatch, the drop_monitor module still doesn't autoload. This is due to libnl not explicitly requesting a family when genl_ctrl_family_resolve is called. Instead of trying to load the module, it dumps the existing registered families via a NLM_F_DUMP message. I'm working on updating libnl to correct this currently and will cc you on the patch. Neil