Thread (17 messages) 17 messages, 4 authors, 2012-05-30

Re: [PATCH v3] drop_monitor: convert to modular building

From: Ben Hutchings <hidden>
Date: 2012-05-17 20:08:22

On Thu, 2012-05-17 at 16:04 -0400, Neil Horman wrote:
When I first wrote drop monitor I wrote it to just build monolithically.  There
is no reason it can't be built modularly as well, so lets give it that
flexibiity.

I've tested this by building it as both a module and monolithically, and it
seems to work quite well

Change notes:

v2)
* fixed for_each_present_cpu loops to be more correct as per Eric D.
* Converted exit path failures to BUG_ON as per Ben H.

v3)
* Converted del_timer to del_timer_sync to close race noted by Ben H.

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: "David S. Miller" <davem@davemloft.net>
CC: Eric Dumazet <redacted>
CC: Ben Hutchings <redacted>
[...]

Reviewed-by: Ben Hutchings <redacted>

Thanks,
Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help