RE: [NET_NEXT RFC PATCH 1/3] ixgbe: add debugfs support
From: Sullivan, Catherine <hidden>
Date: 2012-05-18 17:10:59
From: Stephen Hemminger [mailto:shemminger@vyatta.com] Sent: Wednesday, May 09, 2012 4:10 PM On Wed, 09 May 2012 16:09:40 -0700 Catherine Sullivan [off-list ref] wrote:quoted
This patch adds debugfs support to the ixgbe driver to give users the ability to access kernel information and to simulate kernel events. The filesystem is set up in the following driver/PCI-instance hierarchy: <debugfs> |-- ixgbe |-- PCI instance | |-- attribute files |-- PCI instance |-- attribute files Signed-off-by: Catherine Sullivan <redacted>This should be an optional configuration since it is meant for special case usage. See SKY2_DEBUG
After looking through the kernel, there doesn't seem to be a clear precedence for this. As was pointed out, SKY2_DEBUG is an optional configuration on its own. However regmap uses debugfs, and it is only optional based on CONFIG_DEBUG_FS, which is how this patch is currently set up. This patch does not have much overhead and we would prefer that it be enabled with CONFIG_DEBUG_FS.