Re: [NET_NEXT RFC PATCH 3/3] ixgbe: added reg_ops file to debugfs

On Wed, 2012-05-09 at 16:14 -0700, Stephen Hemminger wrote:

On Wed, 09 May 2012 16:09:50 -0700
Catherine Sullivan [off-list ref] wrote:

quoted

Added the reg_ops file to debugfs with commands to read and write
a register to give users the ability to read and write individual
registers on the fly.

Signed-off-by: Catherine Sullivan <redacted>
---

 drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c |  112 ++++++++++++++++++++++
 1 files changed, 112 insertions(+), 0 deletions(-)

Aren't these registers already in ethtool?

ethtool register access is read-only and would be very heavy-weight for
interactive debugging.  Not sure this is the best interface to
read/write registers, but it's certainly not redundant.

You are also allowing write without any security checking.

The file permissions are set to 0600 so it's root-only.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.