Re: [PATCH] netfilter: xt_HMARK: endian bugs

On Mon, 14 May 2012, Hans Schillstrom wrote:

On Monday 14 May 2012 18:24:34 Eric Dumazet wrote:

quoted

On Mon, 2012-05-14 at 18:09 +0200, Hans Schillstrom wrote:

quoted

This context can contain both le & be machines,
so at least in hmark it make sense

Before jhash() and its shuffle ? What do you mean ?

I want that a Big endian machine should produce the same
hash value independent of flow direction as a Little endian.

OK, I missed ntohl() before calling jhash_3words()

Correct me if I'm wrong here (have no big endian machine available for test)
jhash_3words() and __jhash_final() seems to be "endian" safe.

No, but as Eric wrote: what is the point in forcing the same hash value 
for the same input on big endian and little endian machines? Are you going 
to transfer the hash value between machines?

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary