Re: [PATCH] netfilter: xt_HMARK: endian bugs

On Mon, 2012-05-14 at 18:09 +0200, Hans Schillstrom wrote:

This context can contain both le & be machines,
so at least in hmark it make sense

Before jhash() and its shuffle ? What do you mean ?

Please respin your patch using (__force u16/u32) instead of
useless/expensive ntohs() / ntohl() (in _this_ context of hashing)

If you compare two 32bits values, of course they must have same
ordering, but seeding jhash() is another matter.

(Granted all calls use the same ordering of course)

sparse is great tool, but if you add useless ntohl() calls to make
sparse silent, then its probably better to not use sparse.