Re: [PATCH 1/4] netfilter: ipset: fix timeout value overflow bug

On Mon, 2012-05-14 at 16:36 +0200, Pablo Neira Ayuso wrote:

On Mon, May 14, 2012 at 03:19:49PM +0100, David Laight wrote:

quoted

quoted

--- a/include/linux/netfilter/ipset/ip_set_timeout.h
+++ b/include/linux/netfilter/ipset/ip_set_timeout.h

@@ -30,6 +30,10 @@ ip_set_timeout_uget(struct nlattr *tb)
 {
 	unsigned int timeout = ip_set_get_h32(tb);
 
+	/* Normalize to fit into jiffies */
+	if (timeout > UINT_MAX/1000)
+		timeout = UINT_MAX/1000;
+

Doesn't that rather assume that HZ is 1000 ?

Indeed. I overlooked that. Thanks David.

I dont think so.

1000 here is really MSEC_PER_SEC

(All occurrences should be changed in this file)