Re: [PATCH 1/4] netfilter: ipset: fix timeout value overflow bug
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2012-05-14 14:36:43
Also in:
netfilter-devel
On Mon, May 14, 2012 at 03:19:49PM +0100, David Laight wrote:
quoted
--- a/include/linux/netfilter/ipset/ip_set_timeout.h +++ b/include/linux/netfilter/ipset/ip_set_timeout.h@@ -30,6 +30,10 @@ ip_set_timeout_uget(struct nlattr *tb) { unsigned int timeout = ip_set_get_h32(tb); + /* Normalize to fit into jiffies */ + if (timeout > UINT_MAX/1000) + timeout = UINT_MAX/1000; +Doesn't that rather assume that HZ is 1000 ?
Indeed. I overlooked that. Thanks David. New patch attached fixing this. I've rebased my tree. @Jozsef: BTW, why do we have include/linux/netfilter/ipset/ip_set_timeout.h living under include/linux ? All definitions are private to the kernel. Why not moving that header (and other similar) to include/net ?
Attachments
- 0001-netfilter-ipset-fix-timeout-value-overflow-bug.patch [text/x-diff] 2645 bytes · preview