Thread (11 messages) flat view 11 messages, 4 authors, 2012-05-08

Re: [PATCH] net: compare_ether_addr[_64bits]() has no ordering

From: Joe Perches <joe@perches.com>
Date: 2012-05-08 06:35:39

On Tue, 2012-05-08 at 02:26 -0400, David Miller wrote:
From: Johannes Berg <johannes@sipsolutions.net>
Date: Tue, 08 May 2012 07:25:44 +0200
quoted
I suppose I could fix those first and then later change the type, but I
think having a "compare_ether_addr" function that returns *false* when
they *match* would be rather confusing. I'd rather have
"equal_ether_addr()" that returns *true* when they match.

I guess we could introduce equal_ether_addr() though and slowly convert,
keeping compare_ether_addr() as a sort of wrapper around it.
Indeed, this is one way to proceed.
perhaps is_equal_ether_addr or is_same_ether_addr instead?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help