Thread (9 messages) 9 messages, 4 authors, 2012-04-04

Re: [PATCH] tilepro ethernet driver: fix a few minor issues

From: Chris Metcalf <hidden>
Date: 2012-04-03 23:32:24
Also in: lkml

On 4/3/2012 7:01 PM, Joe Perches wrote:
On Tue, 2012-04-03 at 18:40 -0400, David Miller wrote:
quoted
From: Stephen Rothwell <redacted>
Date: Wed, 4 Apr 2012 08:37:38 +1000
quoted
On Tue, 03 Apr 2012 18:23:35 -0400 (EDT) David Miller [off-list ref] wrote:
quoted
Format the comment:
	/* Like
	 * this.
	 */
not:
	/*
	 * Like
	 * this.
	 */
People may be confused because Documentation/CodingStyle says to use the
latter ...
I refuse to be dragged into this conversation, I'm completely aware
of the exact situation and I've stated my peace on this time and time
again.
I think you'd have less overall upset in yourself and in
other people if you would do more than repeat yourself
on patch submissions via mailing lists.

To my knowledge when the comment block style was added to
CodingStyle in 2006, you didn't mention anything about it.

https://lkml.org/lkml/2006/12/7/41

and I don't see any other mentions from you.

When I suggested adding something specifically for net
and drivers/net, you were at least dispraising.

http://lists.openwall.net/netdev/2012/02/04/59

I think it'd be useful to have this preference you have
for block comment style written out somewhere other than
the email archives.
Interesting back-story.  Obviously it's the various sub-maintainers'
perquisite to request specific comment style, and if Linus doesn't push
back on the sub-maintainers, that's how it is.

David, I concur that it would be useful to make this canonical somewhere,
since folks who are not aware of your preferences will obviously follow the
CodingStyle document until corrected by you, which seems like a pain for
you.  I suspect a modified version of Joe's original CodingStyle change,
along with a comparable change in checkpatch, is the most "scalable" solution.

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help