Re: [PATCH] tilepro ethernet driver: fix a few minor issues
From: David Miller <davem@davemloft.net>
Date: 2012-04-03 22:23:43
Also in:
lkml
From: Chris Metcalf <redacted> Date: Fri, 30 Mar 2012 19:23:35 -0400
This commit fixes a number of issues seen with the driver: - Improve handling of return credits to the hardware shim - Use skb_frag_size() appropriately - Add netpoll support to run console over UDP Signed-off-by: Chris Metcalf <redacted>
Please do not mix pure bug fixes and new features. Submit the pure bug fixes separately for 'net' tree submission and then submit feature additions like netpoll support in a patch targetting the 'net-next' tree.
+ /* Handle completions if needed to make room. */ + /* NOTE: Return NETDEV_TX_BUSY if there is still no room. */
Do not format comments like this, use something like this instead: /* Handle completions if needed to make room. * NOTE: Return NETDEV_TX_BUSY if there is still no room. */
/* Prepare to advance, detecting full queue. */ + /* NOTE: Return NETDEV_TX_BUSY if the queue is full. */
Similarly, combine them up into a single comment.
+ /* Handle completions if needed to make room. */ + /* NOTE: Return NETDEV_TX_BUSY if there is still no room. */
Same here.
/* Copy the commands, or fail. */ + /* NOTE: Return NETDEV_TX_BUSY if the queue is full. */
Again.
+#ifdef CONFIG_NET_POLL_CONTROLLER +/* + * Polling 'interrupt' - used by things like netconsole to send skbs
Format the comment: /* Like * this. */ not: /* * Like * this. */