Re: [PATCH net-next 1/3] gianfar: Add support for byte queue limits.

From
Eric Dumazet <hidden>
Date
2012-03-18 20:20:39
Also in
linuxppc-dev
Reply to
Paul Gortmaker, 2012-03-18
Le dimanche 18 mars 2012 à 12:56 -0400, Paul Gortmaker a écrit :

...
quoted hunk ↗ jump to hunk
 		 * we add this skb back into the pool, if it's the right size
@@ -2557,13 +2568,15 @@ static int gfar_clean_tx_ring(struct gfar_priv_tx_q *tx_queue)
 	}
 
 	/* If we freed a buffer, we can restart transmission, if necessary */
-	if (__netif_subqueue_stopped(dev, tx_queue->qindex) && tx_queue->num_txbdfree)
-		netif_wake_subqueue(dev, tx_queue->qindex);
+	if (__netif_subqueue_stopped(dev, tqi) && tx_queue->num_txbdfree)
+		netif_wake_subqueue(dev, tqi);
 
You can use netif_tx_queue_stopped(txq) here instead of
__netif_subqueue_stopped(dev, tqi) 
quoted hunk ↗ jump to hunk
 	/* Update dirty indicators */
 	tx_queue->skb_dirtytx = skb_dirtytx;
 	tx_queue->dirty_tx = bdp;
 
+	netdev_tx_completed_queue(txq, howmany, bytes_sent);
+
 	return howmany;
 }
 
Thread (17 messages) 17 messages, 3 authors, last reply 2012-03-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help