Re: [PATCH] net: add QCA alx Ethernet driver

On Wed, Mar 21, 2012 at 6:28 PM, Luis R. Rodriguez
[off-list ref] wrote:

On Tue, Feb 28, 2012 at 7:32 PM, David Miller [off-list ref] wrote:

quoted

From: "Huang, Xiong" <redacted>
Date: Wed, 29 Feb 2012 03:11:14 +0000

quoted

We understand your concern.  To support the new chipset, do you
think it's reasonable to upstream it as a new driver, not a
replacement ?

It depends upon how similar the chips are.

OK.

quoted

To be honest tg3, as one example, supports quite a large array of
different pieces of hardware that use the same logical core.

At certain point it becomes a pain in the ass to support older
chipsets, and simply easier to leave the older driver to rot.

quoted

So that would be my litmus test about how different a chip needs
to be to deserve an entirely new driver.

Understood.

quoted

I strongly suggest you try to get atl1c working properly.

This is what I have recommended since the alx driver was rejected, and
our team has been working on the atl1c driver now but we need to get
the legal approval to get contributions out to atl1c (I know this is
silly, but hey just letting you know).

Anyway, in the meantime another topic has creeped up, and that is to
share with BSD and also help kill proprietary drivers [0]. Me and
Adrian intend on sharing our thoughts on how we intend on doing this
at LF collab but was in hopes we can use alx as a test case. We've
gone back to the drawing board for another simple driver to test our
work against but... we come back to alx.

Would it be worthwhile to consider alx upstream only for the newer
chipsets (regardless of the litmus test, which I do agree with on
technical grounds) in consideration for helping pave the way on
killing proprietary drivers?

[0] https://events.linuxfoundation.org/events/collaboration-summit/rodriguez-chadd

David, please us know if you think the above reason is worthy for
consideration of alx upstream, if at least for the newer chipsets. Our
engineers are ready to work on either approach, and we have a approval
take either route now. The sharing benefits however would make this a
great case to work on for the above mentioned project.

  Luis