Re: [PATCH] net: add QCA alx Ethernet driver
flat view
From: Stephen Hemminger <hidden>
Date: 2012-02-29 03:32:41
Also in:
lkml
On Tue, 28 Feb 2012 17:50:09 -0800 "Luis R. Rodriguez" [off-list ref] wrote:
From: Luis R. Rodriguez <redacted> The next patch adds the new QCA alx Ethernet driver that supercedes the atl1c Ethernet driver. For details please read the commit log of the patch. Given the size you can download the patch from: http://bombadil.infradead.org/~mcgrof/2012/02/28/add-alx-next-20120228.patch sha1sum: 8a8f7b6f1cbe737e70ec3b3eda483a6925fd9bd6
Evolution is better. The new driver has lots of new callbacks to handle the fact it is dealing with two different chipsets. Not only that your callbacks are built at runtime which leads to security concerns. There is a reason the two Marvell based drivers (skge and sky2) are different drivers. Having to do extra per-chip callbacks is a clear sign the driver should be split in two.