sendmmsg: put_user vs __put_user
From: Ulrich Drepper <hidden>
Date: 2012-03-30 13:36:44
Also in:
lkml
Subsystem:
networking [general], networking [sockets], the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Kuniyuki Iwashima, Willem de Bruijn, Linus Torvalds
Shouldn't the compat code in the sendmmsg implementation use the same code as the normal code? In which case you probably want something like this:
diff --git a/net/socket.c b/net/socket.c
index 484cc69..ff40409 100644
--- a/net/socket.c
+++ b/net/socket.c@@ -2064,7 +2064,7 @@ int __sys_sendmmsg(int fd, struct mmsghdr __user*mmsg, unsigned int vlen,
&msg_sys, flags, &used_address);
if (err < 0)
break;
- err = __put_user(err, &compat_entry->msg_len);
+ err = put_user(err, &compat_entry->msg_len);
++compat_entry;
} else {
err = __sys_sendmsg(sock, (struct msghdr __user *)entry,