Re: [PATCH] tcp: bind() use stronger condition for bind_conflict

On Wed, Mar 28, 2012 at 5:48 PM, Eric Dumazet [off-list ref] wrote:

On Wed, 2012-03-28 at 10:52 -0300, Flavio Leitner wrote:

quoted

On Wed, 28 Mar 2012 00:11:52 +0300
Alexandru Copot [off-list ref] wrote:

quoted

quoted

diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c
index 02dd203..dfc8bc3 100644
--- a/net/ipv6/inet6_connection_sock.c
+++ b/net/ipv6/inet6_connection_sock.c

@@ -28,7 +28,8 @@

 #include <net/inet6_connection_sock.h>

 int inet6_csk_bind_conflict(const struct sock *sk,
-                       const struct inet_bind_bucket *tb)
+                       const struct inet_bind_bucket *tb,
+                           int relax)

Same here
Maybe you can wait for more feedbacks before spin another patch
version just to fix that.

Also 'int relax' should be 'bool relax'... 1/0 -> true/false

Anyway net-next is not open yet...

Eric, Flavio, thanks a lot for your comments. We will resubmit this
when net-next opens.

Please let us know if you have any other observations.

thanks,
Daniel.