Re: [PATCH 2/3] tcp: Initial repair mode

On 03/29/2012 12:39 AM, Ben Hutchings wrote:

On Wed, 2012-03-28 at 19:37 +0400, Pavel Emelyanov wrote:
[...]

quoted

* Ability to forcibly bind a socket to a port

The sk->sk_reuse is set to 2 denoting, that the socket is question
should be bound as if all the others in the system are configured
with the SO_REUSEADDR option.

Shouldn't this constant be named?

Agree, I will fix this up.

[...]

quoted

--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c

[...]

quoted

+	case TCP_REPAIR_QUEUE:
+		if (!tp->repair)
+			err = -EPERM;
+		else if (val <= TCP_QUEUES_NR)

Off-by-one.

Oops :( Thanks for noticing!

quoted

+			tp->repair_queue = val;
+		else
+			err = -EINVAL;
+		break;

[...]