Re: [PATCH 2/3] tcp: Initial repair mode
From: Ben Hutchings <hidden>
Date: 2012-03-28 20:39:22
On Wed, 2012-03-28 at 19:37 +0400, Pavel Emelyanov wrote: [...]
* Ability to forcibly bind a socket to a port The sk->sk_reuse is set to 2 denoting, that the socket is question should be bound as if all the others in the system are configured with the SO_REUSEADDR option.
Shouldn't this constant be named? [...]
quoted hunk ↗ jump to hunk
--- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c
[...]
+ case TCP_REPAIR_QUEUE: + if (!tp->repair) + err = -EPERM; + else if (val <= TCP_QUEUES_NR)
Off-by-one.
+ tp->repair_queue = val; + else + err = -EINVAL; + break;
[...] -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.