Re: [RFC] skb truesize last offenders

On Fri, 2012-03-23 at 14:38 -0400, David Miller wrote:

From: Eric Dumazet <redacted>
Date: Fri, 23 Mar 2012 05:51:52 -0700

quoted

iwlwifi and some other users of skb_add_rx_frag() lie about skb
truesize, because of API being lazy.

iwlwifi can use order-0 or order-1 pages and skb truesize is wrong.
network sbs can use uncharged kernel memory and eventually crash machine
in OOM.

I plan : 

1) adding a @truesize parameter to skb_add_rx_frag() in a neutral patch

2) fix drivers that dont charge the real size of fragment

3) niu could then use skb_add_rx_frag() instead of custom code.

No objections from me.  But we really have to fix that
tcp_grow_window() issue, it's quite urgent if you ask me.

Sure, I can work on this issue with Neal asap, we do have some ideas on
this subject.