Thread (13 messages) flat view 13 messages, 4 authors, 2012-02-20

Re: [PATCH v2 2/2] adi: adapt to eth_hw_addr_random() and changes in arch/blackfin

From: David Miller <davem@davemloft.net>
Date: 2012-02-20 00:06:15
Also in: lkml

From: Danny Kukawka <redacted>
Date: Fri, 17 Feb 2012 11:57:54 +0100
On Freitag, 17. Februar 2012, Mike Frysinger wrote:
quoted
On Thu, Feb 16, 2012 at 12:09, Danny Kukawka wrote:
quoted
+                       netdev_warn(ndev, "Setting Ethernet MAC to a
random one\n"); +                       eth_hw_addr_random(ndev);
would it make sense to have the core dump the warning ?
Maybe. Many drivers already print information about setting a random mac 
address to a netdevice. Some with printk, some via 
netdev_warn/netdev_info/netdev_dbg or netif_dbg and other with costum 
methods. I could unify this, in a next step with a netdev_info in 
eth_hw_addr_random(), if it's okay for David. 
All of these log messages are stupid and should be removed.

If someone is seriously interested in it, we have the damn random
address boolean state which can be inspected in the sysfs addr_assign_type
node for the device.

End of story.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help