Re: [PATCH v2 2/2] adi: adapt to eth_hw_addr_random() and changes in arch/blackfin

On Samstag, 18. Februar 2012, Joe Perches wrote:

On Fri, 2012-02-17 at 18:15 -0500, Mike Frysinger wrote:

quoted

On Friday 17 February 2012 05:57:54 Danny Kukawka wrote:

quoted

Maybe. Many drivers already print information about setting a random
mac address to a netdevice. Some with printk, some via
netdev_warn/netdev_info/netdev_dbg or netif_dbg and other with costum
methods. I could unify this, in a next step with a netdev_info in
eth_hw_addr_random(), if it's okay for David.

i think unification in the core makes sense.  it enforces consistency and
removes duplication.

It's a good idea.

Okay ... I'll send a patch to print a message via netdev_info from 
eth_hw_addr_random() and to cleanup the drivers.

Danny