Re: [PATCH v2 08/10] ethoc: set addr_assign_type if random_ether_addr() used
From: David Miller <davem@davemloft.net>
Date: 2012-02-17 21:03:53
Also in:
lkml
From: Danny Kukawka <redacted> Date: Fri, 17 Feb 2012 16:43:29 +0100
Set addr_assign_type correctly to NET_ADDR_RANDOM in case
a random MAC address was generated and assigned to the netdevice.
Fixed ethoc_set_mac_address() to check if the given mac
address is valid and set also dev_addr of the net_device.
Check also the return value of ethoc_set_mac_address() in
ethoc_probe().
Reset the state to NET_ADDR_PERM as soon as the MAC get
changed via .ndo_set_mac_address.
v2: set net_device->dev_addr in ethoc_set_mac_address(),
check if given address is valid
Signed-off-by: Danny Kukawka <redacted>Applied, but more coding style problems:
+ if(!is_valid_ether_addr(mac))
Come on, "if[SPACE](..." always.
+
Trailing whitespace.
+ if (ret) {
+ dev_err(&netdev->dev, "failed to set MAC address\n");
+ goto error;
+ }
+ More tailing whitespace.