Thread (21 messages) flat view 21 messages, 2 authors, 2012-02-17

Re: [PATCH v2 07/10] cisco/enic: use eth_hw_addr_random() instead of random_ether_addr()

From: David Miller <davem@davemloft.net>
Date: 2012-02-17 21:01:58
Also in: lkml

From: Danny Kukawka <redacted>
Date: Fri, 17 Feb 2012 16:43:28 +0100
Use dev_hw_addr_random() instead of calling random_ether_addr()
to set addr_assign_type correctly to NET_ADDR_RANDOM.

Couldn't replace random_ether_addr() in enic_probe() since
enic_set_mac_addr() is used which would reset addr_assign_type.
Instead set addr_assign_type directly to NET_ADDR_RANDOM in
case of random mac after call enic_set_mac_addr().

Reset the state to NET_ADDR_PERM as soon as the MAC get
changed via .ndo_set_mac_address.

v2: use bitops, adapt to eth_hw_addr_random(), add a comment

Signed-off-by: Danny Kukawka <redacted>
This patch doesn't apply at all to the current net-next tree,
please always validate that your patches actually apply to the
tree before submission.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help