Re: [PATCH v5 3/5] netdev: ethernet dev_alloc_skb to netdev_alloc_skb
From: David Miller <davem@davemloft.net>
Date: 2012-02-07 20:30:17
Also in:
linux-next, lkml
Subsystem:
networking drivers, sonic network driver, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Thomas Bogendoerfer, Linus Torvalds
From: Geert Uytterhoeven <geert@linux-m68k.org> Date: Tue, 7 Feb 2012 21:04:07 +0100
drivers/net/ethernet/natsemi/sonic.c:425: error: too few arguments to function 'netdev_alloc_skb'
I just wrote and committed the following fix, which took less effort than your report most likely :-) -------------------- sonice: Fix build due to botched netdev_alloc_skb() conversion. Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: David S. Miller <davem@davemloft.net> --- drivers/net/ethernet/natsemi/sonic.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/natsemi/sonic.c b/drivers/net/ethernet/natsemi/sonic.c
index 0452e296..46795e4 100644
--- a/drivers/net/ethernet/natsemi/sonic.c
+++ b/drivers/net/ethernet/natsemi/sonic.c@@ -422,7 +422,7 @@ static void sonic_rx(struct net_device *dev) status = sonic_rda_get(dev, entry, SONIC_RD_STATUS); if (status & SONIC_RCR_PRX) { /* Malloc up new buffer. */ - new_skb = netdev_alloc_skb(SONIC_RBSIZE + 2); + new_skb = netdev_alloc_skb(dev, SONIC_RBSIZE + 2); if (new_skb == NULL) { printk(KERN_ERR "%s: Memory squeeze, dropping packet.\n", dev->name); lp->stats.rx_dropped++;
--
1.7.7.6