Re: [PATCH v5 2/5] netdev: ethernet dev_alloc_skb to netdev_alloc_skb

On Mon, Feb 6, 2012 at 10:19 PM, David Miller [off-list ref] wrote:

From: "Pradeep A. Dalvi" <redacted>
Date: Sun,  5 Feb 2012 18:20:10 +0530

quoted

From: Pradeep A Dalvi <redacted>

Replaced deprecating dev_alloc_skb with netdev_alloc_skb in drivers/net/ethernet
  - Removed extra skb->dev = dev after netdev_alloc_skb

Signed-off-by: Pradeep A Dalvi <redacted>

Applied, but again I had to fix things:

quoted

-    p = dev_alloc_skb(IEEE802_3_SZ + DE4X5_ALIGN + 2);
+     p = netdev_alloc_skb(dev, IEEE802_3_SZ + DE4X5_ALIGN + 2);

 ...

quoted

-    p = dev_alloc_skb(len + 2);
+     p = netdev_alloc_skb(dev, len + 2);

Leave existing indentation alone.

quoted

-             skb = dev_alloc_skb(ugeth->ug_info->uf_info.max_rx_buf_length +
-                                 UCC_GETH_RX_DATA_BUF_ALIGNMENT);
+             skb = netdev_alloc_skb(ugeth->ndev,
+                             ugeth->ug_info->uf_info.max_rx_buf_length +
+                             UCC_GETH_RX_DATA_BUF_ALIGNMENT);

Line up subsequent lines of a multiline series of function arguments
properly, each should start at the first column after the function calls
openning parenthesis.

Thanks a lot again! And would remember about these too.