Re: [PATCH 01/16] eicon: fix -Warray-bounds warning

On Mittwoch, 1. Februar 2012, David Laight wrote:

quoted

-----Original Message-----
From: netdev-owner@vger.kernel.org
[mailto:netdev-owner@vger.kernel.org] On Behalf Of Danny Kukawka
Sent: 31 January 2012 17:04
To: Karsten Keil
Cc: Ben Hutchings; Armin Schindler;
linux-kernel@vger.kernel.org; netdev@vger.kernel.org; Karsten Keil
Subject: Re: [PATCH 01/16] eicon: fix -Warray-bounds warning

On Dienstag, 31. Januar 2012, Karsten Keil wrote:

quoted

On Mon, Jan 30, 2012 at 11:09:32PM +0000, Ben Hutchings wrote:

quoted

On Mon, 2012-01-30 at 23:00 +0100, Danny Kukawka wrote:

quoted

Fix for a -Warray-bounds warning. mixer_notify_update() tries to
write to ((CAPI_MSG *) msg)->info.facility_req.structs[3] while
structs is defined as byte structs[1], define structs[1] as
structs[4].

I suspect that all the 'byte structs[1];' fields defined

in that header

quoted

quoted

are actually variable-length arrays.  In that case, there

may be no

quoted

quoted

reasonable bound you can specify.

Yes, exactely, the structs is a ASN1 coded message so it

can have any len.

So, how can we get rid of the compiler warning then?

Try defining it as a 'variable sized array' - byte structs[0].

Okay, that works. I'll send an updated patch.

Thanks

Danny

	David