Re: [PATCH 01/16] eicon: fix -Warray-bounds warning
From: Ben Hutchings <hidden>
Date: 2012-01-30 23:09:37
Also in:
lkml
On Mon, 2012-01-30 at 23:00 +0100, Danny Kukawka wrote:
Fix for a -Warray-bounds warning. mixer_notify_update() tries to write to ((CAPI_MSG *) msg)->info.facility_req.structs[3] while structs is defined as byte structs[1], define structs[1] as structs[4].
I suspect that all the 'byte structs[1];' fields defined in that header are actually variable-length arrays. In that case, there may be no reasonable bound you can specify. Ben.
quoted hunk ↗ jump to hunk
Signed-off-by: Danny Kukawka <redacted> --- drivers/isdn/hardware/eicon/capi20.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/isdn/hardware/eicon/capi20.h b/drivers/isdn/hardware/eicon/capi20.h index 7ebcccd..f9170ad 100644 --- a/drivers/isdn/hardware/eicon/capi20.h +++ b/drivers/isdn/hardware/eicon/capi20.h@@ -226,7 +226,7 @@ typedef struct { /* FACILITY-REQUEST */ typedef struct { word Selector; - byte structs[1]; /* Facility parameters */ + byte structs[4]; /* Facility parameters */ } _FAC_REQP; /* FACILITY-CONFIRM STRUCT FOR SUPPLEMENT. SERVICES */ typedef struct {
-- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.