Re: [PATCH 1/2] netdev/phy/icplus: Correct broken phy_init code

From: Giuseppe CAVALLARO <redacted>
Date: Wed, 22 Feb 2012 08:24:57 +0100

From: David McKay <redacted>

The code for ip1001_config_init() was totally broken if you were not
using RGMII. Instead of returning an error code or zero it actually
returned the value in the IP1001_SPEC_CTRL_STATUS_2 register. It was
also trying to set the IP1001_APS_ON bit , but never actually wrote
back the register.

The error checking was also incorrect in both this function and the
reset function, so this patch fixes that up in a consistent fashion.

Signed-off-by: David McKay <redacted>
Signed-off-by: Giuseppe Cavallaro <redacted>

Applied.