Re: [PATCH v2 2/2] netdev: driver: ethernet: Add TI CPSW driver

On Thu, Feb 23, 2012 at 07:46:02AM -0800, Joe Perches wrote:

On Thu, 2012-02-23 at 12:47 +0000, N, Mugunthan V wrote:

quoted

Joe/David

quoted

quoted

-----Original Message-----
From: Joe Perches [mailto:joe@perches.com]
Sent: Tuesday, February 21, 2012 4:34 AM

[...]

quoted

quoted

Add
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before all #includes and remove the embedded prefix
from all pr_<level> uses.

Agreed, will make use of pr_fmt and remove embedded prefix in pr_<level>
uses

Adding 
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
in the driver gives a checkpatch error as follows
#77: FILE: drivers/net/ethernet/ti/cpsw.c:16:
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
total: 1 errors, 0 warnings, 1137 lines checked
Is it ok to ignore the checkpatch error as most of the drivers use it.

Yes.

Andy Whitcroft has a pending checkpatch fix
for this.  I hope he pushes it out soon.

Bah good reminder.  Will get those re-tested and out as soon as I can
...

-apw