RE: [PATCH v2 2/2] netdev: driver: ethernet: Add TI CPSW driver

Joe/David

-----Original Message-----
From: N, Mugunthan V
Sent: Wednesday, February 22, 2012 10:13 PM
To: 'Joe Perches'
Cc: netdev@vger.kernel.org; davem@davemloft.net
Subject: RE: [PATCH v2 2/2] netdev: driver: ethernet: Add TI CPSW driver

Joe

quoted

-----Original Message-----
From: Joe Perches [mailto:joe@perches.com]
Sent: Tuesday, February 21, 2012 4:34 AM

[...]

quoted

Add
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before all #includes and remove the embedded prefix
from all pr_<level> uses.

Agreed, will make use of pr_fmt and remove embedded prefix in pr_<level>
uses

Adding 
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
in the driver gives a checkpatch error as follows

#77: FILE: drivers/net/ethernet/ti/cpsw.c:16:
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

total: 1 errors, 0 warnings, 1137 lines checked

Is it ok to ignore the checkpatch error as most of the drivers use it.

[...] 

With regards
Mugunthan V N