Re: [PATCH] 3c59x: shorten timer period for slave devices
From: Dan Williams <hidden>
Date: 2012-02-14 20:50:14
On Tue, 2012-02-14 at 21:27 +0100, Eric Dumazet wrote:
Jean Delvare reported bonding on top of 3c59x adapters was not detecting network cable removal fast enough. 3c59x indeed uses a 60 seconds timer to check link status if carrier is on, and 5 seconds if carrier is off. This patch reduces timer period to 5 seconds if device is a bonding slave.
Maybe for posterity give some rationale as to why we feel we can reduce it to 5 seconds for slaves instead of reducing the timer period in general? If you weren't party to this discussion that won't be apparent from the commit log. Dan
quoted hunk ↗ jump to hunk
Reported-by: Jean Delvare <redacted> Acked-by: Jean Delvare <redacted> Acked-by: Steffen Klassert <steffen.klassert@secunet.com> Signed-off-by: Eric Dumazet <redacted> --- drivers/net/ethernet/3com/3c59x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/ethernet/3com/3c59x.c b/drivers/net/ethernet/3com/3c59x.c index 1282f04..e463d10 100644 --- a/drivers/net/ethernet/3com/3c59x.c +++ b/drivers/net/ethernet/3com/3c59x.c@@ -1841,7 +1841,7 @@ vortex_timer(unsigned long data) ok = 1; } - if (!netif_carrier_ok(dev)) + if (dev->flags & IFF_SLAVE || !netif_carrier_ok(dev)) next_tick = 5*HZ; if (vp->medialock) --To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html