Thread (18 messages) flat view 18 messages, 9 authors, 2012-02-15

Re: bonding with 3c59x driver

From: David Miller <davem@davemloft.net>
Date: 2012-02-14 19:50:38

From: Steffen Klassert <redacted>
Date: Tue, 14 Feb 2012 14:34:18 +0100
On Tue, Feb 14, 2012 at 01:50:57PM +0100, Jean Delvare wrote:
quoted
quoted
We could have a 5 sec timer in case device is a slave.
diff --git a/drivers/net/ethernet/3com/3c59x.c
 b/drivers/net/ethernet/3com/3c59x.c index 1282f04..e463d10 100644
--- a/drivers/net/ethernet/3com/3c59x.c
+++ b/drivers/net/ethernet/3com/3c59x.c
@@ -1841,7 +1841,7 @@ vortex_timer(unsigned long data)
 		ok = 1;
 	}

-	if (!netif_carrier_ok(dev))
+	if (dev->flags & IFF_SLAVE || !netif_carrier_ok(dev))
 		next_tick = 5*HZ;

 	if (vp->medialock)
Yes I think this makes a lot of sense. If you send this upstream you can 
add:

Acked-by: Jean Delvare <redacted>
I'm fine with this too.
Eric, please submit this formally.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help