Re: [RFC] netpoll: netpoll_poll_dev() should access dev->flags
From: Neil Horman <nhorman@tuxdriver.com>
Date: 2012-02-14 13:28:14
On Tue, Feb 14, 2012 at 12:10:21PM +0100, Eric Dumazet wrote:
commit 5a698af53f (bond: service netpoll arp queue on master device) use a dubious test : if (dev->priv_flags & IFF_SLAVE) It seems to me IFF_SLAVE is present on dev->flags only ? What am I missing ?
I want to say there was a reason for checking priv_flags, but if there was, it escapes me now. Either way, ->flags is definately what we want now. Acked-by: Neil Horman <nhorman@tuxdriver.com>
quoted hunk ↗ jump to hunk
diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 4ce473e..3d84fb9 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c@@ -205,7 +205,7 @@ static void netpoll_poll_dev(struct net_device *dev) poll_napi(dev); - if (dev->priv_flags & IFF_SLAVE) { + if (dev->flags & IFF_SLAVE) { if (dev->npinfo) { struct net_device *bond_dev = dev->master; struct sk_buff *skb;