Thread (5 messages) 5 messages, 3 authors, 2012-02-10

Re: [patch] bna: fix error handling of bnad_get_flash_partition_by_offset()

From: David Miller <davem@davemloft.net>
Date: 2012-02-09 20:44:47
Also in: kernel-janitors

From: Dan Carpenter <redacted>
Date: Thu, 9 Feb 2012 13:49:34 +0300
The current error handling doesn't work because we flash_part is a u32
so the checks for negative error codes don't work.  I considered making
things signed but I don't know the hardware enough to say if that's a
problem.  Really, we don't use the error codes so just returning zero
for all problems is fine.

Signed-off-by: Dan Carpenter <redacted>
Looks good, applied, thanks Dan.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help