Thread (18 messages) 18 messages, 5 authors, 2012-02-09

Re: [net 3/8] ixgbe: fix vf lookup

From: Jeff Kirsher <hidden>
Date: 2012-02-09 09:06:27

On Wed, 2012-02-08 at 18:33 -0500, David Miller wrote:
From: Jeff Kirsher <redacted>
Date: Wed,  8 Feb 2012 01:36:33 -0800
quoted
-             if (pvfdev->devfn == vf_devfn)
+             if (pvfdev->devfn == vf_devfn &&
+                             (pvfdev->bus->number >=
pdev->bus->number))

Come on.... do you look at these patches at all?

I don't think you did, because this kind of code formatting stuff
sticks out like a sore thumb. 
Your right, I over-looked this, and it is especially bad since I caught
the problem with the igb patch (which was right before this one).  I
remember thinking that I need to make sure the ixgbe patch did not have
the same formatting issue.  But completely forgot before I applied the
patch.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help