RE: [PATCH] tcp: RST: binding oif to iif for tcp v4
From: Eric Dumazet <hidden>
Date: 2012-02-04 19:10:02
Subsystem:
networking [general], networking [tcp], the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Neal Cardwell, Linus Torvalds
Le samedi 04 février 2012 à 13:42 -0500, Shawn Lu a écrit :
Eric: Yes, you are right. It helps if we do as your suggested. Do you want to send out a patch to address this?
All I was saying was that if sk is not NULL, it must have precedence. So you could prepare/submit a patch amended by what I said, so that we can make progress ?
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 90e4793..ca2348f 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c@@ -676,6 +676,7 @@ static void tcp_v4_send_reset(struct sock *sk, struct sk_buff *skb) arg.iov[0].iov_len, IPPROTO_TCP, 0); arg.csumoffset = offsetof(struct tcphdr, check) / 2; arg.flags = (sk && inet_sk(sk)->transparent) ? IP_REPLY_ARG_NOSRCCHECK : 0; + arg.bound_dev_if = sk ? sk->sk_bound_dev_if : inet_iif(skb); net = dev_net(skb_dst(skb)->dev); arg.tos = ip_hdr(skb)->tos;