RE: [PATCH] tcp: RST: binding oif to iif for tcp v4

Le vendredi 03 février 2012 à 16:43 -0500, Shawn Lu a écrit :

See inline.
-----Original Message-----
From: Eric Dumazet [mailto:eric.dumazet@gmail.com] 
Le vendredi 03 février 2012 à 12:16 -0800, Shawn Lu a écrit :

quoted

Binding RST packet outgoing interface to incomming interface for tcp 
v4. This has few benefits:
1. tcp_v6_send_reset already did that.

I dont think so. ipv6 makes no special provision for RST.
[shawn LU] it's in  tcp_v6_send_response line 899 of tcp_ipv6.c
 fl6.flowi6_oif = inet6_iif(skb);

tcp_v6_send_response() is used to send RST _and_ ACK

Its not reserved to RST. Thats why I said "no _special_ provision for
RST"

I repeat my question :

Why do you believe only RST should be handled in a different manner than
other TCP messages ?

If we decide to break asymmetric routing, we should do it completely and
document it.

It might already be broken for IPv6 and nobody cared / noticed.