Re: [PATCH/RESEND] drivers/net/ethernet: dev_alloc_skb to netdev_alloc_skb
From: Joe Perches <joe@perches.com>
Date: 2012-01-23 18:40:52
Also in:
lkml
On Mon, 2012-01-23 at 23:58 +0530, Pradeep A. Dalvi wrote:
Replaced deprecating dev_alloc_skb with netdev_alloc_skb in drivers/net/ethernet - Removed extra skb->dev = dev after netdev_alloc_skb
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/amd/lance.c b/drivers/net/ethernet/amd/lance.c
[]
quoted hunk ↗ jump to hunk
@@ -871,13 +871,12 @@ lance_init_ring(struct net_device *dev, gfp_t gfp) struct sk_buff *skb; void *rx_buff; - skb = alloc_skb(PKT_BUF_SZ, GFP_DMA | gfp); + skb = netdev_alloc_skb(dev, PKT_BUF_SZ);
This change seems suspect. I stopped reading here. Perhaps you should break this large patch into multiple separate patches. The trivial, obviously correct and the possibly broken.