Re: [PATCH 2/5] SUNRPC: create unix gid cache per network namespace
From: J. Bruce Fields <hidden>
Date: 2012-01-19 16:24:38
Also in:
linux-nfs, lkml
On Thu, Jan 19, 2012 at 06:49:14PM +0400, Stanislav Kinsbursky wrote:
This patch makes unix_gid_cache cache detail allocated and registered per network namespace context. Thus with this patch unix_gid_cache contents for network namespace "X" are controlled from proc file system mount for the same network namespace "X".
I'm confused--this seems half-done. I see that you're creating the gid caches dynamically, but there's still this static definition:
struct cache_detail unix_gid_cache = {
.owner = THIS_MODULE,
.hash_size = GID_HASHMAX,
- .hash_table = gid_table,
.name = "auth.unix.gid",
.cache_put = unix_gid_put,
.cache_upcall = unix_gid_upcall,And it looks like unix_gid_lookup is still using this static unix_gid_cache. Maybe I'm missing something.... --b.